Messages in this thread | | | Date | Thu, 27 Nov 2008 01:31:51 +0300 | From | Anton Vorontsov <> | Subject | Re: [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio() |
| |
On Thu, Nov 27, 2008 at 08:38:51AM +1100, Paul Mackerras wrote: [...] > > > drivers/mtd/nand/fsl_upm.c | 2 +- > > > drivers/net/fs_enet/fs_enet-main.c | 2 +- > > > drivers/net/phy/mdio-ofgpio.c | 4 ++-- > > > drivers/of/gpio.c | 13 ++++++++++--- > > > drivers/serial/cpm_uart/cpm_uart_core.c | 2 +- > > > include/linux/of_gpio.h | 21 +++++++++++++++++---- > > > 6 files changed, 32 insertions(+), 12 deletions(-) > > That would need acks from Jeff Garzik and David Woodhouse. > > Alternatively you could add a new function (called, for instance, > of_get_gpio_flags) with the extra parameter to eliminate the need to > change any drivers at this stage, since they all seem to pass NULL for > the flags argument.
:-))
This was _exactly_ my initial approach, but Trent and Grant thought that changing API would be easy. Hah-ha!
Here is my initial patch implementing of_get_gpio_flags(): http://lkml.org/lkml/2008/7/25/236
Trent, are you going to push your patch through all the maintainers, or should we, after all, revert to my approach instead?
Thanks,
-- Anton Vorontsov email: cbouatmailru@gmail.com irc://irc.freenode.net/bd2
| |