lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH v2] of_gpio: Return GPIO flags from of_get_gpio()
On Thu, 27 Nov 2008, Paul Mackerras wrote:
> Anton Vorontsov writes:
>
>> Can we apply it? Paul, Benjamin?
>>
>> The patchwork url for this patch is:
>> http://patchwork.ozlabs.org/patch/6650/
>>
>>
>> Thanks!
>>
>>> drivers/mtd/nand/fsl_upm.c | 2 +-
>>> drivers/net/fs_enet/fs_enet-main.c | 2 +-
>>> drivers/net/phy/mdio-ofgpio.c | 4 ++--
>>> drivers/of/gpio.c | 13 ++++++++++---
>>> drivers/serial/cpm_uart/cpm_uart_core.c | 2 +-
>>> include/linux/of_gpio.h | 21 +++++++++++++++++----
>>> 6 files changed, 32 insertions(+), 12 deletions(-)
>
> That would need acks from Jeff Garzik and David Woodhouse.
>
> Alternatively you could add a new function (called, for instance,
> of_get_gpio_flags) with the extra parameter to eliminate the need to
> change any drivers at this stage, since they all seem to pass NULL for
> the flags argument.

But if we did this every time any exported function needs to change, think
how bloated the API would be with cruft.


\
 
 \ /
  Last update: 2008-11-26 23:39    [W:0.092 / U:0.412 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site