lkml.org 
[lkml]   [2008]   [Nov]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/3] ftrace: add function tracing to single thread

* Eric W. Biederman <ebiederm@xmission.com> wrote:

> Steven Rostedt <rostedt@goodmis.org> writes:
>
> > On Tue, 25 Nov 2008, Eric W. Biederman wrote:
> >
> > I'm speechless too.
>
> I'm a bit tired so probably am pushing to hard.
>
> At the same time I don't see a single reason not to use struct pid
> for what it was designed for. Identifying tasks. pid_t's really
> only belong at the border.
>
> I can see in the tracer when grabbing numbers you might not be able
> to follow pointers. For that I see justification for using
> task->pid. For the comparison I just don't see it.

i dont see the point of the complexity you are advocating. 99.9% of
the users run a unique PID space.

Tracing is about keeping stuff simple. On containers we could also
trace the namespace ID (is there an easy ID for the namespace, as an
easy extension to the very nice PID concept that Unix introduced
decades ago?) and be done with it.

Ingo


\
 
 \ /
  Last update: 2008-11-26 07:35    [from the cache]
©2003-2011 Jasper Spaans