Messages in this thread | | | From | (Eric W. Biederman) | Date | Tue, 25 Nov 2008 22:23:16 -0800 | Subject | Re: [PATCH 1/3] ftrace: add function tracing to single thread |
| |
Steven Rostedt <rostedt@goodmis.org> writes:
> On Tue, 25 Nov 2008, Eric W. Biederman wrote: > >> >> > > I'm speechless too.
I'm a bit tired so probably am pushing to hard.
At the same time I don't see a single reason not to use struct pid for what it was designed for. Identifying tasks. pid_t's really only belong at the border.
I can see in the tracer when grabbing numbers you might not be able to follow pointers. For that I see justification for using task->pid. For the comparison I just don't see it.
Eric
| |