Messages in this thread | | | Subject | Re: [patch 1/2] mm: change dirty limit type specifiers to unsigned long | From | Peter Zijlstra <> | Date | Mon, 24 Nov 2008 20:16:41 +0100 |
| |
On Sun, 2008-11-23 at 10:55 -0800, David Rientjes wrote: > The background dirty and dirty limits are better defined with type > specifiers of unsigned long since negative writeback thresholds are not > possible. > > These values, as returned by get_dirty_limits(), are normally compared > with ZVC values to determine whether writeback shall commence or be > throttled. Such page counts cannot be negative, so declaring the page > limits as signed is unnecessary. > > Cc: Peter Zijlstra <peterz@infradead.org> > Cc: Dave Chinner <david@fromorbit.com> > Cc: Christoph Lameter <cl@linux-foundation.org> > Signed-off-by: David Rientjes <rientjes@google.com>
This didn't pop up any weird and wonderfull assumptions on the signed-ness of these variables I take it :-)
Acked-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
| |