lkml.org 
[lkml]   [2008]   [Nov]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: include ENTRY/END in entry handlers in entry_64.S

* Alexander van Heukelum <heukelum@mailshack.com> wrote:

> Impact: cleanup of entry_64.S
>
> Except for the order and the place of the functions, this
> patch should not change the generated code.
>
> Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm>
>
> ---
> arch/x86/kernel/entry_64.S | 259 +++++++++++++++++++-------------------------
> 1 files changed, 109 insertions(+), 150 deletions(-)

applied to tip/x86/irq, thanks Alexander!

> > Something like:
> >
> > PARANOID_ERROR_ENTRY(stack_segment)
>
> I chose to just reuse the existing names, but it's bikeshedding, so
> change it if you like ;)

yeah. But such things, if they pile up long enough, can result in real
problem. entry_64.S is the result of such a degenerative process.

> I now know why I did not hit the bug that was fixed by "x86: split
> out some macro's and move common code to paranoid_exit, fix"...
> *blush* I was doing my real-world testing using an i386-image of
> debian.

heh, that indeed explains :)

Ingo


\
 
 \ /
  Last update: 2008-11-23 14:27    [W:0.145 / U:0.068 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site