Messages in this thread | | | Date | Sun, 23 Nov 2008 14:35:40 +0300 | From | Cyrill Gorcunov <> | Subject | Re: [PATCH] x86: include ENTRY/END in entry handlers in entry_64.S |
| |
[Alexander van Heukelum - Sun, Nov 23, 2008 at 12:23:54PM +0100] | On Sun, Nov 23, 2008 at 12:21:36PM +0300, Cyrill Gorcunov wrote: | > [Alexander van Heukelum - Sun, Nov 23, 2008 at 10:08:28AM +0100] | > | Impact: cleanup of entry_64.S | > | | > | Except for the order and the place of the functions, this | > | patch should not change the generated code. | > | | > | Signed-off-by: Alexander van Heukelum <heukelum@fastmail.fm> | > | | > | --- | > | arch/x86/kernel/entry_64.S | 259 +++++++++++++++++++------------------------- | > | 1 files changed, 109 insertions(+), 150 deletions(-) | > | | > | > Hi Alexander, | > | > great! One moment is not obvious for me -- why we | > stopped to align interrupt section to 32 bytes? | > Did I miss anyhing? | | I put a ".p2align 5" in earlier in the series which caused the | apicinterrupts to be 32-byte aligned. But it is a hack, really, | relying on the generated code per stub to be between 17 and 32 | bytes, on the default alignment to be 16 bytes and all stubs | to be in the .text section. | | I'm in favour of aligning all of the interrupt/exception stubs | to 32 bytes, but it should be implemented the right way ;), | which means that we need KPROBE_ENTRY_P5ALIGNED and so on :-/. | | Greetings, | Alexander | | > - Cyrill - |
ah. thanks for info.
- Cyrill -
| |