Messages in this thread | | | Date | Thu, 20 Nov 2008 13:03:14 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 2.6.28-rc5 04/11] kmemleak: Add modules support |
| |
small nit:
> +#else > +static inline void memleak_load_module(struct module *mod, Elf_Ehdr *hdr, > + Elf_Shdr *sechdrs, char *secstrings) > +{ } > +#endif
this looks nicer:
static inline void memleak_load_module(struct module *mod, Elf_Ehdr *hdr, Elf_Shdr *sechdrs, char *secstrings) { }
We dont use "{ }" in other places in the kernel, so lets not invent a new style if possible.
> + /* the pointer to this block is stored in the module structure > + * which is inside the block. Just mark it as not being a > + * leak */
Comment style.
> + /* the pointer to this block is stored in the module structure > + * which is inside the block. This block doesn't need to be > + * scanned as it contains data and code that will be freed > + * after the module is initialized */
ditto.
Thanks,
Ingo
| |