Messages in this thread Patch in this message | | | Date | Wed, 19 Nov 2008 20:00:07 -0800 | From | Hiroshi Shimamoto <> | Subject | Re: [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 |
| |
Yinghai Lu wrote: > Ingo Molnar wrote: >> hm, one of my testboxes is rather unhappy about your patch: > > > please check > > if you agree, will update update_genapic to autodetect other functions or etc. > > YH > > --- > > [PATCH] x86: fix wakeup_cpu with numaq/es7000 v2 - fix > > Impact: fix wakeup_secondary_cpu with hotplug > > We can not put that in x86_quirks, because that is __initdata. > So try to move that to genapic, and add update_genapic in x86_quirks. > > later we even could use that stub to > 1. autodetect CONFIG_ES7000_CLUSTERED_APIC > 2. more correct inquire_remote_apic with apic_verbosity setting.
Hi,
I encountered boot failure on x86_32 box. I think setting wakeup_cpu is missing.
-------- From: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> Subject: [PATCH] x86: genapic: fix missing wakeup_cpu setup
Impact: fix boot failure
There is no way to setup wakeup_cpu when boot parameter apic= is not passed.
Signed-off-by: Hiroshi Shimamoto <h-shimamoto@ct.jp.nec.com> --- arch/x86/mach-generic/probe.c | 3 +++ 1 files changed, 3 insertions(+), 0 deletions(-)
diff --git a/arch/x86/mach-generic/probe.c b/arch/x86/mach-generic/probe.c index 90b134f..bde6e36 100644 --- a/arch/x86/mach-generic/probe.c +++ b/arch/x86/mach-generic/probe.c @@ -98,6 +98,9 @@ void __init generic_apic_probe(void) /* Not visible without early console */ if (!apic_probe[i]) panic("Didn't find an APIC driver"); + + if (x86_quirks->update_genapic) + x86_quirks->update_genapic(); } printk(KERN_INFO "Using APIC driver %s\n", genapic->name); } -- 1.5.6
| |