lkml.org 
[lkml]   [2008]   [Nov]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] x86: Support always running TSC on Intel CPUs

* Venki Pallipadi <venkatesh.pallipadi@intel.com> wrote:

> + if (c->x86_power & (1 << 8)) {
> set_cpu_cap(c, X86_FEATURE_CONSTANT_TSC);
> + set_cpu_cap(c, X86_FEATURE_NOSTOP_TSC);
> + }

hm, the naming is a bit confusing. We now have 3 variants:

X86_FEATURE_TSC
X86_FEATURE_CONSTANT_TSC
X86_FEATURE_NOSTOP_TSC

NOSTOP_TSC is basically what CONSTANT_TSC should have been to begin
with ;-)

i'd suggest to rename it to this:

X86_FEATURE_TSC
X86_FEATURE_CONSTANT_FREQ_TSC
X86_FEATURE_STABLE_TSC

... with CONSTANT_FREQ_TSC not having any real role in the long run.
(it's similarly problematic to a completely unstable TSC)

does this sound ok?

Ingo


\
 
 \ /
  Last update: 2008-11-18 09:13    [W:0.495 / U:0.524 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site