lkml.org 
[lkml]   [2008]   [Nov]   [16]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 3/4] tracing/branch-tracer: Fix a trace recursion on branch tracer

* Frederic Weisbecker <fweisbec@gmail.com> wrote:

> Impact: Make the branch tracer use raw irq save/restore
>
> When the branch tracer inserts an event through
> probe_likely_condition(), it calls local_irq_save() and then results
> in a trace recursion.
>
> local_irq_save() -> trace_hardirqs_off() -> trace_hardirqs_off_caller()
> -> unlikely()
>
> The trace_branch.c file is protected by DISABLE_BRANCH_PROFILING but
> that doesn't prevent from external call to functions that use
> unlikely().
>
> My box crashed each time I tried to set this tracer (sudden and hard
> reboot).

So this patch fixes that problem, or are there other problems left?

Ingo


\
 
 \ /
  Last update: 2008-11-16 07:25    [W:0.027 / U:0.176 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site