Messages in this thread | | | Date | Wed, 12 Nov 2008 16:01:39 -0200 | From | Arnaldo Carvalho de Melo <> | Subject | Re: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage |
| |
Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu: > * Arnaldo Carvalho de Melo (acme@redhat.com) wrote: > > diff --git a/include/linux/marker.h b/include/linux/marker.h > > index 889196c..6213b5e 100644 > > --- a/include/linux/marker.h > > +++ b/include/linux/marker.h > > @@ -12,6 +12,7 @@ > > * See the file COPYING for more details. > > */ > > > > +#include <stdarg.h> > > Hrm given it's already included in kernel.h for printk, I am not sure > it's required here ? Although it cannot hurt to add it explicitly.
Well, its just that while writing code I noticed that if I included marker.h as the first include the compilation would fail.
My impression was that if you use something, you should include its definition, not relying on the includes hell.
> Mathieu > > > #include <linux/types.h> > > > > struct module;
| |