lkml.org 
[lkml]   [2008]   [Nov]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] markers: Add missing stdargs.h include, needed due to va_list usage
* Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> Em Wed, Nov 12, 2008 at 12:21:47PM -0500, Mathieu Desnoyers escreveu:
> > * Arnaldo Carvalho de Melo (acme@redhat.com) wrote:
> > > diff --git a/include/linux/marker.h b/include/linux/marker.h
> > > index 889196c..6213b5e 100644
> > > --- a/include/linux/marker.h
> > > +++ b/include/linux/marker.h
> > > @@ -12,6 +12,7 @@
> > > * See the file COPYING for more details.
> > > */
> > >
> > > +#include <stdarg.h>
> >
> > Hrm given it's already included in kernel.h for printk, I am not sure
> > it's required here ? Although it cannot hurt to add it explicitly.
>
> Well, its just that while writing code I noticed that if I included
> marker.h as the first include the compilation would fail.
>
> My impression was that if you use something, you should include its
> definition, not relying on the includes hell.
>

Ok,

Acked-by: Mathieu Desnoyers <mathieu.desnoyers@polymtl.ca>

Thanks,

Mathieu

> > Mathieu
> >
> > > #include <linux/types.h>
> > >
> > > struct module;

--
Mathieu Desnoyers
OpenPGP key fingerprint: 8CD5 52C3 8E3C 4140 715F BA06 3F25 A8FE 3BAE 9A68


\
 
 \ /
  Last update: 2008-11-12 19:51    [W:0.470 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site