lkml.org 
[lkml]   [2008]   [Oct]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation
On Fri, 3 Oct 2008 13:27:18 +0200
"Rafael J. Wysocki" <rjw@sisk.pl> wrote:

> On Friday, 3 of October 2008, Andrew Morton wrote:
> > On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki"
> > <rjw@sisk.pl> wrote:
> >
> > > Hibernation: Introduce new system state for the last phase of
> > > hibernation
> > >
> > > Replace unused SYSTEM_SUSPEND_DISK with a new system_state value
> > > SYSTEM_HIBERNATE_ENTER that can be used by device drivers to
> > > check if the system is in the last phase of hibernation.
> >
> > Violent objections.
> >
> > We just don't know what this change will do. It potentially affects
> > every code site in the kernel which looks at system_state.
>
> Do you mean anyone checking 'system_state != SOMETHING' ? Oh well.

I think Andrew also means things looking for system_state > something
like

arch/powerpc/platforms/cell/smp.c: if (system_state < SYSTEM_RUNNING &&
arch/powerpc/kernel/smp.c: if (system_state < SYSTEM_RUNNING)
arch/powerpc/kernel/smp.c: if (system_state > SYSTEM_BOOTING)
drivers/xen/xenbus/xenbus_probe.c: if (system_state > SYSTEM_RUNNING) {


--
Arjan van de Ven Intel Open Source Technology Centre
For development, discussion and tips for power savings,
visit http://www.lesswatts.org


\
 
 \ /
  Last update: 2008-10-03 14:53    [W:1.217 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site