Messages in this thread | | | From | "Rafael J. Wysocki" <> | Subject | Re: [PATCH 1/6] Hibernation: Introduce new system state for the last phase of hibernation | Date | Fri, 3 Oct 2008 13:27:18 +0200 |
| |
On Friday, 3 of October 2008, Andrew Morton wrote: > On Tue, 30 Sep 2008 00:10:37 +0200 "Rafael J. Wysocki" <rjw@sisk.pl> wrote: > > > Hibernation: Introduce new system state for the last phase of hibernation > > > > Replace unused SYSTEM_SUSPEND_DISK with a new system_state value > > SYSTEM_HIBERNATE_ENTER that can be used by device drivers to check if > > the system is in the last phase of hibernation. > > Violent objections. > > We just don't know what this change will do. It potentially affects > every code site in the kernel which looks at system_state.
Do you mean anyone checking 'system_state != SOMETHING' ? Oh well.
> We've had problems in the past with this thing and the more complex we make it, > the worse any future problems will be. It's Just Bad. > > Can we just create a new global? > > extern bool system_entering_hibernation_or_whatever;
Yes, we can, but what about:
extern bool system_entering_hibernation(void);
that will become a static inline in case of !CONFIG_HIBERNATION, and using a static variable?
| |