Messages in this thread | | | From | "Guo-Fu Tseng" <> | Subject | Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset | Date | Sun, 12 Oct 2008 22:12:26 +0800 |
| |
On Sun, 12 Oct 2008 09:59:03 -0400, Jeff Layton wrote > On Sun, 12 Oct 2008 08:40:39 -0500 > "Steve French" <smfrench@gmail.com> wrote: > > > Rafael and Guo-Fu, > > The following change to address the compile error that you noted is > > slightly different than what you suggested but should fix what you > > found. > > > > Actually, I like Adrian/Rafael's fix better. I think we should avoid > cluttering up the code with #ifdef's where possible. key_put() already > is a no-op when CONFIG_KEYS is disabled. We might as well do the same > thing with key_revoke(). I found that my patch was not reasonable at all. And I agree with Jeff.
Guo-Fu Tseng
| |