Messages in this thread | | | Date | Sun, 12 Oct 2008 11:53:19 -0500 | From | "Steve French" <> | Subject | Re: [linux-cifs-client] Fwd: [PATCH] Fix CIFS compilation with CONFIG_KEYS unset |
| |
On Sun, Oct 12, 2008 at 8:59 AM, Jeff Layton <jlayton@redhat.com> wrote: > On Sun, 12 Oct 2008 08:40:39 -0500 > "Steve French" <smfrench@gmail.com> wrote: > >> Rafael and Guo-Fu, >> The following change to address the compile error that you noted is >> slightly different than what you suggested but should fix what you >> found. >> > > Actually, I like Adrian/Rafael's fix better. I think we should avoid > cluttering up the code with #ifdef's where possible. key_put() already > is a no-op when CONFIG_KEYS is disabled. We might as well do the same > thing with key_revoke(). I don't think it matters much - but we probably shouldn't be overriding global functions.
-- Thanks,
Steve
| |