Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] mm: unify shmem and tiny-shmem | Date | Wed, 01 Oct 2008 16:00:01 +0100 |
| |
Matt Mackall <mpm@selenic.com> wrote:
> (This applies on top of Nick's second tiny-shmem patch, which hasn't > made it to mainline yet(!). But as this deletes tiny-shmem.c, you can > probably ignore the rejects.) > > tiny-shmem shares most of its 130 lines of code with shmem and tends > to break when particular bits of shmem get modified. Unifying saves > code and makes keeping these two in sync much easier. > > before: > 14367 392 24 14783 39bf mm/shmem.o > 396 72 8 476 1dc mm/tiny-shmem.o > > after: > 14367 392 24 14783 39bf mm/shmem.o > 412 72 8 492 1ec mm/shmem.o tiny > > Signed-off-by: Matt Mackall <mpm@selenic.com>
Works with my test program:
http://people.redhat.com/~dhowells/doshm.c
Compile and run:
doshm sysv
warthog>size mm/tiny-shmem.o text data bss dec hex filename 788 36 4 828 33c mm/tiny-shmem.o warthog>size mm/shmem.o text data bss dec hex filename 832 36 4 872 368 mm/shmem.o
Acked-by: David Howells <dhowells@redhat.com>
| |