lkml.org 
[lkml]   [2008]   [Oct]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] mm: unify shmem and tiny-shmem
Date
Matt Mackall <mpm@selenic.com> wrote:

> (This applies on top of Nick's second tiny-shmem patch, which hasn't
> made it to mainline yet(!). But as this deletes tiny-shmem.c, you can
> probably ignore the rejects.)
>
> tiny-shmem shares most of its 130 lines of code with shmem and tends
> to break when particular bits of shmem get modified. Unifying saves
> code and makes keeping these two in sync much easier.
>
> before:
> 14367 392 24 14783 39bf mm/shmem.o
> 396 72 8 476 1dc mm/tiny-shmem.o
>
> after:
> 14367 392 24 14783 39bf mm/shmem.o
> 412 72 8 492 1ec mm/shmem.o tiny
>
> Signed-off-by: Matt Mackall <mpm@selenic.com>

Works with my test program:

http://people.redhat.com/~dhowells/doshm.c

Compile and run:

doshm sysv

warthog>size mm/tiny-shmem.o
text data bss dec hex filename
788 36 4 828 33c mm/tiny-shmem.o
warthog>size mm/shmem.o
text data bss dec hex filename
832 36 4 872 368 mm/shmem.o


Acked-by: David Howells <dhowells@redhat.com>


\
 
 \ /
  Last update: 2008-10-01 17:09    [W:0.100 / U:0.160 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site