lkml.org 
[lkml]   [2008]   [Oct]   [2]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [PATCH] mm: unify shmem and tiny-shmem
From
Date

On Thu, 2008-10-02 at 23:23 +0100, David Howells wrote:
> Hugh Dickins <hugh@veritas.com> wrote:
>
> > That's much nicer than I'd been imagining, thanks Matt: I've no qualms
> > about the few #ifdefs you're adding to mm/shmem.c, it does seem an
> > outright improvement that you're bringing them together.
>
> It's not an outright improvement. shmem.o is still larger than tiny-shmem.o,
> albeit not a lot; however, some embedded people really do count the bytes.

Here the difference comes down to 16 bytes for the "if (size < 0)"
check/branch, which is a worthwhile check.
> > This ifndef is the ugliest part of it: and looking into it, guess
> > what, shmem_get_unmapped_area() hasn't been used since 2.6.20 -
> > that's right, isn't it, David?
>
> Ummm... It seems to be. I think it used to be used by SYSV SHM. Certainly
> deleting that function causes no link problems.

I've got a patch queued to drop it, will post shortly.

--
Mathematics is the supreme nostalgia of our time.



\
 
 \ /
  Last update: 2008-10-03 00:49    [from the cache]
©2003-2011 Jasper Spaans