Messages in this thread | | | Date | Tue, 8 Jan 2008 15:39:45 +0100 | From | DM <> | Subject | Re: [patch 2/2] track and print last unloaded module in the oops trace |
| |
On Jan 8, 2008 3:26 PM, Arjan van de Ven <arjan@infradead.org> wrote: > > > > Why use sprintf? If a module name contains the % character we could > > overflow the buffer. Or is module-unloading root-only and we don't > > care? > > module loading isn't just root only; the name comes from an already loaded module. > If you can load kernel modules of your choice you own the entire kernel already anway >
Still, strcpy seems like a better choice IMHO.
/DM
| |