lkml.org 
[lkml]   [2008]   [Jan]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [patch 2/2] track and print last unloaded module in the oops trace
On Jan 7, 2008 12:19 AM, Arjan van de Ven <arjan@infradead.org> wrote:
[...]
> This patch tracks the last unloaded module, and prints this as part of the
> module list in the oops trace.
>
[...]
> }
> + /* Store the name of the last unloaded module for diagnostic purposes */
> + sprintf(last_unloaded_module, mod->name);
> free_module(mod);
>

Why use sprintf? If a module name contains the % character we could
overflow the buffer. Or is module-unloading root-only and we don't
care?

Best regards,
dm.n9107


\
 
 \ /
  Last update: 2008-01-08 14:55    [W:0.048 / U:4.788 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site