Messages in this thread | | | Date | Tue, 8 Jan 2008 14:51:37 +0100 | From | DM <> | Subject | Re: [patch 2/2] track and print last unloaded module in the oops trace |
| |
On Jan 7, 2008 12:19 AM, Arjan van de Ven <arjan@infradead.org> wrote: [...] > This patch tracks the last unloaded module, and prints this as part of the > module list in the oops trace. > [...] > } > + /* Store the name of the last unloaded module for diagnostic purposes */ > + sprintf(last_unloaded_module, mod->name); > free_module(mod); >
Why use sprintf? If a module name contains the % character we could overflow the buffer. Or is module-unloading root-only and we don't care?
Best regards, dm.n9107
| |