| Date | Sat, 26 Jan 2008 17:27:48 +0100 (CET) | From | Jan Engelhardt <> | Subject | Re: [PATCH 11/52] [microblaze] kernel modules support |
| |
On Jan 24 2008 16:02, monstr@monstr.eu wrote: >+ >+/* module handling */ >+EXPORT_SYMBOL(PAGE_OFFSET);
This looks really ugly. PAGE_OFFSET is usually a macro. I looked in patch 29/52 where PAGE_OFFSET is defined (unsigned int PAGE_OFFSET), which got me wondered: PAGE_OFFSET can be a runtime variable when it is a constant on most other arches?
That being said, I'd use
#define PAGE_OFFSET __page_offset
in some header file and in the .c file:
unsigned int __page_offset; EXPORT_SYMBOL(__page_offset);
that is how arch-frv and -uml seem to do it.
|