Messages in this thread | | | Date | Sun, 27 Jan 2008 16:12:52 +0100 (CET) | From | Geert Uytterhoeven <> | Subject | Re: [PATCH 17/52] [microblaze] checksum support |
| |
On Sun, 27 Jan 2008, Michal Simek wrote: > > So basically this is a copy of arch/m68knommu/lib/checksum.c, with some > > checkpatch.pl fixes but without the sparse fixes? > > Furthermore, it's just plain C, so maybe we need a common one that can > > be shared by multiple archs? > > > > I have no sparse errors and warning in checksum.c file.
How come csum_partial_copy_from_user() in arch/m68knommu/lib/checksum.c has a __user attribute on the src parameter, while yours doesn't?
Gr{oetje,eeting}s,
Geert
-- Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But when I'm talking to journalists I just say "programmer" or something like that. -- Linus Torvalds
| |