[lkml]   [2008]   [Jan]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
Messages in this thread
SubjectRe: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU
On Thu, Jan 10, 2008 at 10:58:57AM +0100, Andi Kleen wrote:
> > It seems the correct solution would be not to hijack __cpuinit
> > (as your patch does), but to create a new annotation.
> The rationale is that after suspend the CPU has to be reinitialized.
> That is because it is essentially like a reboot. All the previous
> CPU state is gone.

But your patch does:

+config PM_CPUINIT
+ bool
+ depends on PM
+ default y

As an example, even plain ACPI support without any suspend support in
the kernel at all requires CONFIG_PM and therefore forces all __cpuinit
code to be non-__init after your patch.

And if the dependency was corrected to PM_SLEEP it will still make
the UP kernel use more memory since we currently have __cpuinit code
that gets discarded after boot but suspend/resume is apparently working.

Plus my other point that it seems to be wrong to do whatever change only
for x86.

> -Andi



"Is there not promise of rain?" Ling Tan asked suddenly out
of the darkness. There had been need of rain for many days.
"Only a promise," Lao Er said.
Pearl S. Buck - Dragon Seed

 \ /
  Last update: 2008-01-10 11:23    [W:0.081 / U:0.796 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site