Messages in this thread | | | Date | Thu, 10 Jan 2008 13:26:07 +0200 | From | Adrian Bunk <> | Subject | Re: [PATCH x86] [15/16] Force __cpuinit on for CONFIG_PM without HOTPLUG_CPU |
| |
On Thu, Jan 10, 2008 at 12:15:15PM +0100, Andi Kleen wrote: > > But your patch does: > > > > +config PM_CPUINIT > > + bool > > + depends on PM > > That is because arch/x86/power/cpu.c where this happens is currently > > obj-$(CONFIG_PM) += cpu.o > > If it was changed to CONFIG_something else then yes that dependency > should be changed too.
Then fix this first.
And the following other points you didn't bother to reply to also still stand even after this fix: - already __cpuinit code will waste memory with CONFIG_PM_SLEEP=y - change shouldn't be x86 specific
> -Andi
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
| |