Messages in this thread Patch in this message | | | Subject | Re: [SCSI] aic94xx: new driver | From | David Woodhouse <> | Date | Fri, 10 Aug 2007 23:09:22 +0800 |
| |
On Sun, 2006-09-24 at 04:00 +0000, Linux Kernel Mailing List wrote: > --- a/include/scsi/scsi.h > +++ b/include/scsi/scsi.h > @@ -429,4 +429,10 @@ #define SCSI_IOCTL_GET_BUS_NUMBER 0x5386 > /* Used to obtain the PCI location of a device */ > #define SCSI_IOCTL_GET_PCI 0x5387 > > +/* Pull a u32 out of a SCSI message (using BE SCSI conventions) */ > +static inline u32 scsi_to_u32(u8 *ptr) > +{ > + return (ptr[0]<<24) + (ptr[1]<<16) + (ptr[2]<<8) + ptr[3]; > +} > + > #endif /* _SCSI_SCSI_H */
Please explain why it's necessary to export this to userspace.
The files in /usr/include/scsi are actually shipped by glibc, and most distributions use glibc's version instead of the one from the kernel -- so this additional userspace interface is automatically incompatible with most people's installations.
It would perhaps make sense to stop glibc providing these files, and let distributions use the version from the kernel -- but that's a separate issue. And still doesn't seem to justify the addition of the above function.
-- dwmw2 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |