Messages in this thread Patch in this message | | | Date | Tue, 3 Jul 2007 21:00:45 -0300 | From | Diego Woitasen <> | Subject | [PATCH] Remove unneeded lock_kernel() in drivers/block/loop.c |
| |
This patch remove the unneeded lock_kernel() in drivers/block/loop.c. I read the code as this lock_kernel() doesn't protect anything. Loopback code use lo_ctl_mutex for syncronization.
diff --git a/drivers/block/loop.c b/drivers/block/loop.c index 0ed5470..1cc004e 100644 --- a/drivers/block/loop.c +++ b/drivers/block/loop.c @@ -1286,7 +1286,6 @@ static long lo_compat_ioctl(struct file *file, unsigned int cmd, unsigned long a struct loop_device *lo = inode->i_bdev->bd_disk->private_data; int err; - lock_kernel(); switch(cmd) { case LOOP_SET_STATUS: mutex_lock(&lo->lo_ctl_mutex); @@ -1312,7 +1311,6 @@ static long lo_compat_ioctl(struct file *file, unsigned int cmd, unsigned long a err = -ENOIOCTLCMD; break; } - unlock_kernel(); return err; } #endif
--
-------------- Diego Woitasen - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |