Messages in this thread | | | Date | Thu, 19 Jul 2007 09:29:51 +0100 | From | Christoph Hellwig <> | Subject | Re: [NFS] [PATCH 5/5] knfsd: clean up EX_RDONLY |
| |
On Wed, Jul 18, 2007 at 06:57:30PM -0400, J. Bruce Fields wrote: > From: J. Bruce Fields <bfields@citi.umich.edu> > > Share a little common code, reverse the arguments for consistency, drop > the unnecessary "inline", and lowercase the name.
Ah, sorry - didn't notice this was a separate patch.
> @@ -1845,7 +1838,7 @@ nfsd_permission(struct svc_rqst *rqstp, struct svc_export *exp, > */ > if (!(acc & MAY_LOCAL_ACCESS)) > if (acc & (MAY_WRITE | MAY_SATTR | MAY_TRUNC)) { > - if (EX_RDONLY(exp, rqstp) || IS_RDONLY(inode)) > + if (exp_rdonly(rqstp, exp) || IS_RDONLY(inode))
In fact with just a singler caller left and reduced to a one-liner we could kill this function completely.. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |