lkml.org 
[lkml]   [2007]   [Jul]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [NFS] [PATCH 4/5] knfsd: move EX_RDONLY out of header
On Thu, 19 Jul 2007 09:28:38 +0100 Christoph Hellwig <hch@infradead.org> wrote:

> On Wed, Jul 18, 2007 at 06:57:29PM -0400, J. Bruce Fields wrote:
> > From: J. Bruce Fields <bfields@citi.umich.edu>
> >
> > EX_RDONLY is only called in one place; just put it there.
> >
> > Signed-off-by: "J. Bruce Fields" <bfields@citi.umich.edu>
> > ---
> > fs/nfsd/vfs.c | 12 ++++++++++++
> > include/linux/nfsd/export.h | 12 ------------
> > 2 files changed, 12 insertions(+), 12 deletions(-)
> >
> > diff --git a/fs/nfsd/vfs.c b/fs/nfsd/vfs.c
> > index 5c97d0e..f2684e5 100644
> > --- a/fs/nfsd/vfs.c
> > +++ b/fs/nfsd/vfs.c
> > @@ -1797,6 +1797,18 @@ nfsd_statfs(struct svc_rqst *rqstp, struct svc_fh *fhp, struct kstatfs *stat)
> > return err;
> > }
> >
> > +static inline int EX_RDONLY(struct svc_export *exp, struct svc_rqst *rqstp)
> > +{
> > + struct exp_flavor_info *f;
> > + struct exp_flavor_info *end = exp->ex_flavors + exp->ex_nflavors;
> > +
> > + for (f = exp->ex_flavors; f < end; f++) {
> > + if (f->pseudoflavor == rqstp->rq_flavor)
> > + return f->flags & NFSEXP_READONLY;
> > + }
> > + return exp->ex_flags & NFSEXP_READONLY;
> > +}
>
> As mentioned last time lease remove the inline qualifier and give it a
> lower-case name.

that's the next patch in the series.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-19 10:41    [W:0.094 / U:0.060 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site