lkml.org 
[lkml]   [2007]   [Jul]   [18]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
Subject[PATCH][ACPI] Fix acpi_ev_pci_config_region_setup() to avoid memory leak
Date
Hello,

In drivers/acpi/events/evrgnini.c::acpi_ev_pci_config_region_setup()
there is a memory leak.
We may return at "if (!pci_device_node)" without freeing storage
previously allocated and assigned to 'pci_id'.
This patch fixes the leak by freeing the allocated storage in this
case.

Compile tested only...


Signed-off-by: Jesper Juhl <jesper.juhl@gmail.com>
---

drivers/acpi/events/evrgnini.c | 1 +
1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/events/evrgnini.c b/drivers/acpi/events/evrgnini.c
index 400d90f..10f378b 100644
--- a/drivers/acpi/events/evrgnini.c
+++ b/drivers/acpi/events/evrgnini.c
@@ -284,6 +284,7 @@ acpi_ev_pci_config_region_setup(acpi_handle handle,
}

if (!pci_device_node) {
+ kfree(pci_id);
return_ACPI_STATUS(AE_AML_OPERAND_TYPE);
}


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-07-19 00:51    [W:0.450 / U:0.048 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site