Messages in this thread | | | Date | Thu, 21 Jun 2007 12:30:47 +0200 | From | "Robert Richter" <> | Subject | Re: [patch 2/8] 2.6.22-rc3 perfmon2 : Debug messages added |
| |
On 20.06.07 13:22:16, Stephane Eranian wrote: > David, > > On Wed, Jun 20, 2007 at 12:49:05PM -0700, David Rientjes wrote: > > On Wed, 20 Jun 2007, Robert Richter wrote: > > > > > Debug messages added for better debugging. > > > > > > > And you added BUG_ON()'s. > > > > > Signed-off-by: Robert Richter <robert.richter@amd.com> > > > > > > Index: linux-2.6.22-rc3/perfmon/perfmon_file.c > > > =================================================================== > > > --- linux-2.6.22-rc3.orig/perfmon/perfmon_file.c > > > +++ linux-2.6.22-rc3/perfmon/perfmon_file.c > > > @@ -192,6 +192,8 @@ static int pfm_mmap(struct file *file, s > > > unsigned long flags; > > > int ret; > > > > > > + PFM_DBG("pfm_file_ops"); > > > > After commenting on your first set of patches, I've been using it a little > > more. In my use, these debugging messages weren't very helpful because > > "pfm_file_ops" can indicate pfm_mmap, pfm_read, pfm_poll, etc. Could > > these be changed to be more specific based on the function they're in? > > > the PFM_DBG() macro adds the CPU, function name and line number to the > printed string.
Right, I had this in mind.
-Robert
-- AMD Saxony, Dresden, Germany Operating System Research Center email: robert.richter@amd.com
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |