lkml.org 
[lkml]   [2007]   [Jun]   [10]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [PATCH] PCI: also read revision ID for sparc64, ppc, read class at the same time
    From
    Date
    On Sat, 2007-06-09 at 13:12 -0700, Auke Kok wrote:
    > Since the PCI bus class and revision are in the same dword, we
    > can fill in both in the same read.
    >
    > Other non-x86 arches use different methods to fill in these values,
    > make sure to adjust those too.
    >
    > Signed-off-by: Auke Kok <auke-jan.h.kok@intel.com>
    > ---
    >
    > arch/powerpc/kernel/pci_64.c | 2 ++
    > arch/sparc64/kernel/pci.c | 1 +
    > drivers/pci/probe.c | 4 +---
    > 3 files changed, 4 insertions(+), 3 deletions(-)
    >
    > diff --git a/arch/powerpc/kernel/pci_64.c b/arch/powerpc/kernel/pci_64.c
    > index 249cca2..b2c55ca 100644
    > --- a/arch/powerpc/kernel/pci_64.c
    > +++ b/arch/powerpc/kernel/pci_64.c
    > @@ -367,8 +367,10 @@ struct pci_dev *of_create_pci_dev(struct device_node *node,
    > sprintf(pci_name(dev), "%04x:%02x:%02x.%d", pci_domain_nr(bus),
    > dev->bus->number, PCI_SLOT(devfn), PCI_FUNC(devfn));
    > dev->class = get_int_prop(node, "class-code", 0);
    > + dev->revision = get_int_prop(node, "revision-id", 0);

    It's not clear to me in the spec if nodes are required to have the
    "revision-id" property. I guess 0 is a safe default though.

    cheers

    --
    Michael Ellerman
    OzLabs, IBM Australia Development Lab

    wwweb: http://michael.ellerman.id.au
    phone: +61 2 6212 1183 (tie line 70 21183)

    We do not inherit the earth from our ancestors,
    we borrow it from our children. - S.M.A.R.T Person
    [unhandled content-type:application/pgp-signature]
    \
     
     \ /
      Last update: 2007-06-10 13:27    [W:0.029 / U:35.608 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site