lkml.org 
[lkml]   [2007]   [May]   [1]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Date
From
SubjectRe: [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.
On Fri, 27 Apr 2007, Linux Kernel Mailing List wrote:
> [AF_RXRPC]: Make the in-kernel AFS filesystem use AF_RXRPC.
>
> Make the in-kernel AFS filesystem use AF_RXRPC instead of the old RxRPC code.

> --- a/fs/afs/fsclient.c
> +++ b/fs/afs/fsclient.c

> + if (call->count < PAGE_SIZE) {
> + buffer = kmap_atomic(call->reply3, KM_USER0);
^^^^^^^^^^^^

This causes a compile failure on m68k:

| linux/fs/afs/fsclient.c: In function 'afs_deliver_fs_fetch_data':
| linux/fs/afs/fsclient.c:269: warning: dereferencing 'void *' pointer
| linux/fs/afs/fsclient.c:269: error: request for member 'virtual' in something not a structure or union

Probably you wanted to assign call->reply3 to a struct page pointer first, like you do for the call->unmarshall == 2 case.

Signed-off-by: Geert Uytterhoeven <geert@linux-m68k.org>

--- linux-m68k-2.6.21/fs/afs/fsclient.c
+++ linux-m68k-2.6.21/fs/afs/fsclient.c
@@ -266,7 +266,8 @@ static int afs_deliver_fs_fetch_data(str
call->unmarshall++;

if (call->count < PAGE_SIZE) {
- buffer = kmap_atomic(call->reply3, KM_USER0);
+ page = call->reply3;
+ buffer = kmap_atomic(page, KM_USER0);
memset(buffer + PAGE_SIZE - call->count, 0,
call->count);
kunmap_atomic(buffer, KM_USER0);

Gr{oetje,eeting}s,

Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-05-01 17:43    [W:1.722 / U:0.876 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site