Messages in this thread Patch in this message | | | Subject | [PATCH] fix process crash caused by randomisation and 64k pages | From | James Bottomley <> | Date | Fri, 16 Mar 2007 12:57:18 -0500 |
| |
This bug was seen on ppc64, but it could have occurred on any architecture with a page size of 64k or above. The problem is that fs/binfmt_elf.c:randomize_stack_top() randomizes the stack to within 0x7ff pages. On 4k page machines, this is 8MB; on 64k page boxes, this is 128MB. The problem is that the new binary layout (selected in arch_pick_mmap_layout) places the mapping segment 128MB or the stack rlimit away from the top of the process memory, whichever is larger. If you chose an rlimit of less than 128MB (most defaults are in the 8Mb range) then you can end up having your entire stack randomized away.
The fix is to make randomize_stack_top() only steal at most 8MB, which this patch does. However, I have to point out that even with this, your stack rlimit might not be exactly what you get if it's > 128MB, because you're still losing the random offset of up to 8MB.
The true fix should be to leave an explicit gap for the randomization plus a buffer when determining mmap_base, but that would involve fixing all the architectures.
James
diff --git a/fs/binfmt_elf.c b/fs/binfmt_elf.c index 51db118..187f151 100644 --- a/fs/binfmt_elf.c +++ b/fs/binfmt_elf.c @@ -507,7 +507,7 @@ out: #define INTERPRETER_ELF 2 #ifndef STACK_RND_MASK -#define STACK_RND_MASK 0x7ff /* with 4K pages 8MB of VA */ +#define STACK_RND_MASK 0x7ff0000 /* 8MB of VA */ #endif static unsigned long randomize_stack_top(unsigned long stack_top) @@ -515,14 +515,12 @@ static unsigned long randomize_stack_top(unsigned long stack_top) unsigned int random_variable = 0; if ((current->flags & PF_RANDOMIZE) && - !(current->personality & ADDR_NO_RANDOMIZE)) { + !(current->personality & ADDR_NO_RANDOMIZE)) random_variable = get_random_int() & STACK_RND_MASK; - random_variable <<= PAGE_SHIFT; - } #ifdef CONFIG_STACK_GROWSUP - return PAGE_ALIGN(stack_top) + random_variable; + return PAGE_ALIGN(stack_top + random_variable); #else - return PAGE_ALIGN(stack_top) - random_variable; + return PAGE_ALIGN(stack_top - random_variable); #endif }
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |