lkml.org 
[lkml]   [2007]   [Feb]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: [PATCH] free swap space when (re)activating page
Date
Rik van Riel <riel@redhat.com> wrote:

+++ linux-2.6.20.noarch/mm/swap.c        2007-02-20 06:44:17.000000000 -0500
@@ -420,6 +420,26 @@ void pagevec_strip(struct pagevec *pvec)

> +                        if (printk_ratelimit())
> +                                printk("kswapd freed a swap space\n");
>

NOOOOOOOOOOOOOOOOOOOOOOOOOOOOOO!!!!!!!!!!!

1) This message is a debug message! You forgot to set the printk level.

2) The message text is bad, the average log reader only knows swap files
and pages in swapfiles. The first reaction will be like "WTF happened
to my swap???". Thousands of admins will cry out in anguish trying to
get the meaning of this message, and again cry out in wrath after they
found out.
3) What should I do if I see this message? It's neither good, nor bad for
me, nor is it in any way informative even if it were changed to be
meaningfull. It's utterly useless! Let it be!

--
We are all born ignorant, but one must work hard to remain stupid.
-- Benjamin Franklin

Friß, Spammer: JEN-ersdiT@kowaZ.7eggert.dyndns.org
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-02-23 02:45    [W:0.048 / U:0.148 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site