Messages in this thread | | | Date | Sun, 30 Dec 2007 16:51:38 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc. |
| |
On Sun, 30 Dec 2007, Ingo Molnar wrote:
> > * Julia Lawall <julia@diku.dk> wrote: > > > > your x86 patches (#7, #8 and #9) do not include any *_eq() > > > comparisons and they all seem to be correct. So picked those three > > > up into x86.git - let me know if there's any breakage in them that i > > > missed. > > > > Only #7 is ok. The other two have #include <jiffies.h> in the wrong > > place. I will send new versions of #8 and #9 shortly. > > hm, #include file order in a .c file should normally not matter - why > are they in the wrong place?
Because they are under #ifdefs, but the code that uses the time functions is not under the same #ifdef.
julia
| |