Messages in this thread | | | Date | Sun, 30 Dec 2007 15:55:46 +0100 (CET) | From | Julia Lawall <> | Subject | Re: [PATCH 7/38] arch/x86/ia32: Use time_before, time_before_eq, etc. |
| |
On Sun, 30 Dec 2007, Ingo Molnar wrote:
> > * Julia Lawall <julia@diku.dk> wrote: > > > On Mon, 24 Dec 2007, Andi Kleen wrote: > > > > > On Mon, Dec 24, 2007 at 03:23:19PM +0100, Julia Lawall wrote: > > > > From: Julia Lawall <julia@diku.dk> > > > > > > > > The functions time_before, time_before_eq, time_after, and time_after_eq > > > > are more robust for comparing jiffies against other values. > > > > > > The old code was actually correct I think, but the change is ok for me. > > > > Please ignore the patch. All of my before_eq and after_eq's are > > backwards due to parsing <= as >= and vice versa. I will try again. > > your x86 patches (#7, #8 and #9) do not include any *_eq() comparisons > and they all seem to be correct. So picked those three up into x86.git - > let me know if there's any breakage in them that i missed.
Only #7 is ok. The other two have #include <jiffies.h> in the wrong place. I will send new versions of #8 and #9 shortly.
julia
| |