lkml.org 
[lkml]   [2007]   [Dec]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
SubjectRe: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol
From
From: Andrew Morton <akpm@linux-foundation.org>
Date: Tue, 11 Dec 2007 16:57:00 -0800

> On Sun, 9 Dec 2007 22:34:33 +0100
> Marcin __lusarz <marcin.slusarz@gmail.com> wrote:
>
> > fbcon: fix sparse warning about shadowing 'p' symbol
> >
>
> Please always quote error messages and warnings in the changelog when
> fixing them, thanks.
>
> > ---
> > drivers/video/console/fbcon.c | 10 +++++-----
> > 1 files changed, 5 insertions(+), 5 deletions(-)
> >
> > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c
> > index 0f32f4a..849e114 100644
> > --- a/drivers/video/console/fbcon.c
> > +++ b/drivers/video/console/fbcon.c
> > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines)
> > {
> > struct fb_info *info = registered_fb[con2fb_map[fg_console]];
> > struct fbcon_ops *ops = info->fbcon_par;
> > - struct display *p = &fb_display[fg_console];
> > + struct display *disp = &fb_display[fg_console];
>
> We have a global symbol called "p"? That would be bad. Where is it?

I'm curious about this too.

Ahh, I see, look down a few lines in fbcon_scrolldelta(), we have:

if (logo_shown == vc->vc_num) {
unsigned long p, q;
int i;

and that's where the warning is coming from.


\
 
 \ /
  Last update: 2007-12-12 20:25    [W:0.100 / U:0.016 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site