Messages in this thread | | | Date | Tue, 11 Dec 2007 16:57:00 -0800 | From | Andrew Morton <> | Subject | Re: [PATCH] fbcon: fix sparse warning about shadowing 'p' symbol |
| |
On Sun, 9 Dec 2007 22:34:33 +0100 Marcin __lusarz <marcin.slusarz@gmail.com> wrote:
> fbcon: fix sparse warning about shadowing 'p' symbol >
Please always quote error messages and warnings in the changelog when fixing them, thanks.
> --- > drivers/video/console/fbcon.c | 10 +++++----- > 1 files changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/video/console/fbcon.c b/drivers/video/console/fbcon.c > index 0f32f4a..849e114 100644 > --- a/drivers/video/console/fbcon.c > +++ b/drivers/video/console/fbcon.c > @@ -2795,7 +2795,7 @@ static int fbcon_scrolldelta(struct vc_data *vc, int lines) > { > struct fb_info *info = registered_fb[con2fb_map[fg_console]]; > struct fbcon_ops *ops = info->fbcon_par; > - struct display *p = &fb_display[fg_console]; > + struct display *disp = &fb_display[fg_console];
We have a global symbol called "p"? That would be bad. Where is it?
(The patch is good anwyay - "p" is a poorly chosen identifier here).
| |