lkml.org 
[lkml]   [2007]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite()
    On Mon, Oct 08, 2007 at 04:37:00PM +1000, Nick Piggin wrote:
    > On Tuesday 09 October 2007 02:54, Peter Zijlstra wrote:
    > > It seems that with the recent usage of ->page_mkwrite() a little detail
    > > was overlooked.
    > >
    > > .22-rc1 merged OCFS2 usage of this hook
    > > .23-rc1 merged XFS usage
    > > .24-rc1 will most likely merge NFS usage
    > >
    > > Please consider this for .23 final and maybe even .22.x
    > >
    > > ---
    > > Subject: mm: set_page_dirty_balance() vs ->page_mkwrite()
    > >
    > > All the current page_mkwrite() implementations also set the page dirty.
    > > Which results in the set_page_dirty_balance() call to _not_ call balance,
    > > because the page is already found dirty.
    > >
    > > This allows us to dirty a _lot_ of pages without ever hitting
    > > balance_dirty_pages(). Not good (tm).
    > >
    > > Force a balance call if ->page_mkwrite() was successful.
    >
    > Would it be better to just have the callers set_page_dirty_balance()?

    block_page_mkwrite() is just using generic interfaces to do this,
    same as pretty much any write() system call. The idea was to make it
    as similar to the write() call path as possible...

    However, unlike generic_file_buffered_write(), we are not calling
    balance_dirty_pages_ratelimited(mapping) between
    ->prepare/commit_write call pairs. Perhaps this should be added to
    block_page_mkwrite() after the page is unlocked....

    Cheers,

    Dave.
    --
    Dave Chinner
    Principal Engineer
    SGI Australian Software Group
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-09 01:39    [W:0.024 / U:0.856 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site