lkml.org 
[lkml]   [2007]   [Oct]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] mm: set_page_dirty_balance() vs ->page_mkwrite()
    On Mon, Oct 08, 2007 at 05:47:52PM +1000, Nick Piggin wrote:
    > > block_page_mkwrite() is just using generic interfaces to do this,
    > > same as pretty much any write() system call. The idea was to make it
    > > as similar to the write() call path as possible...
    > >
    > > However, unlike generic_file_buffered_write(), we are not calling
    > > balance_dirty_pages_ratelimited(mapping) between
    > > ->prepare/commit_write call pairs. Perhaps this should be added to
    > > block_page_mkwrite() after the page is unlocked....
    >
    > That sounds pretty sane, in terms of matching with
    > generic_file_buffered_write.

    I agree. We could also insert a call to balance_dirty_pages_ratelimited() in
    __ocfs2_page_mkwrite.
    --Mark

    --
    Mark Fasheh
    Senior Software Developer, Oracle
    mark.fasheh@oracle.com
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2007-10-09 04:17    [W:0.020 / U:0.544 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site