lkml.org 
[lkml]   [2007]   [Oct]   [29]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device
Dirk Hohndel wrote:
> [INPUT] hidinput_connect incorrectly ignored return value from input_register_device
>
> Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com>
>
> ---
> drivers/hid/hid-input.c | 12 ++++++++++--
> 1 files changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/hid/hid-input.c b/drivers/hid/hid-input.c
> index dd332f2..880161b 100644
> --- a/drivers/hid/hid-input.c
> +++ b/drivers/hid/hid-input.c
> @@ -1186,13 +1186,21 @@ int hidinput_connect(struct hid_device *hid)
> * UGCI) cram a lot of unrelated inputs into the
> * same interface. */
> hidinput->report = report;
> - input_register_device(hidinput->input);
> + if (input_register_device(hidinput->input)) {
> + input_free_device(hidinput->input);
> + kfree(hidinput);
> + return -1;
> + }
> hidinput = NULL;
> }
> }
>
> if (hidinput)
> - input_register_device(hidinput->input);
> + if (input_register_device(hidinput->input)) {
> + input_free_device(hidinput->input);
> + kfree(hidinput);
> + return -1;

ACK, thanks for revising



-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2007-10-29 10:37    [W:0.060 / U:22.736 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site