Messages in this thread | | | Date | Mon, 29 Oct 2007 08:54:59 -0400 | From | "Dmitry Torokhov" <> | Subject | Re: [PATCH] INPUT: fix hidinput_connect ignoring retval from input_register_device |
| |
On 10/29/07, Jiri Kosina <jikos@jikos.cz> wrote: > On Mon, 29 Oct 2007, Dirk Hohndel wrote: > > > [INPUT] hidinput_connect incorrectly ignored return value from > > input_register_device > > Signed-off-by: Dirk Hohndel <hohndel@linux.intel.com> > > Will apply
Please don't - the fix is completely broken for multi-input devices - if 2nd device fails to register we bail out of hidinput_connect and thus never set HID_CLAIMED_INPUT bit. So when we disconnect device we never call hidinput_disconnect and who knows what will happen after that.
hidinput_connect() should properly unwind already registered devices after failure.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |