Messages in this thread | | | Subject | RE: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq if it is already there. | Date | Mon, 8 Jan 2007 14:56:21 -0800 | From | "Lu, Yinghai" <> |
| |
-----Original Message----- From: ebiederm@xmission.com [mailto:ebiederm@xmission.com] Sent: Monday, January 08, 2007 2:50 PM To: Andrew Morton Cc: Linus Torvalds; Tobias Diedrich; Adrian Bunk; Andi Kleen; Linux Kernel Mailing List; Lu, Yinghai Subject: [PATCH] x86_64 ioapic: check_timer_pin Don't add_pin_to_irq if it is already there.
>Yep. My oversight. Here is the trivial patch to fix it. I don't >see how we could hit this case but if we are going to allow for it >we should handle it correctly.
Yes, in your check_timer calling sequence, at that point irq can not be 0. ( remove_irq_to_pin already remove that entry).
Or in check_timer_pin
+ if ((irq != -1) && (irq != 0)) {
==>
+ if (irq != -1) {
YH
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |