Messages in this thread | | | Date | Wed, 31 Jan 2007 18:19:57 +0100 | From | Ingo Molnar <> | Subject | Re: [PATCH 08/23] clocksource: drop duplicate register checking |
| |
* Daniel Walker <dwalker@mvista.com> wrote:
> > if (is_registered_source(c)) { > > printk("register_clocksource: Cannot register %s. " > > "Already registered!", c->name); > > ret = -EBUSY; > > > > and Thomas' change keeps that property, but doesnt printk. Your > > change makes double registry possible, potentially crashing the > > kernel later on! (And this isnt theoretical, double registry did > > happen in practice when i debugged suspend problems on my SMP > > laptop.) > > My original patch set makes the duplicate register checking better > (which I dropped) .. I'll be happy to reintroduce that part of it..
why if Thomas' patch: simplify-the-registration-of-clocksources.patch already does it?
Ingo - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |