Messages in this thread Patch in this message | | | Date | Fri, 12 Jan 2007 13:48:42 +0100 | From | Ingo Molnar <> | Subject | [patch] audit: fix audit_filter_user_rules() initialization bug |
| |
From: Ingo Molnar <mingo@elte.hu> Subject: [patch] audit: fix audit_filter_user_rules() initialization bug
gcc emits this warning:
kernel/auditfilter.c: In function 'audit_filter_user': kernel/auditfilter.c:1611: warning: 'state' is used uninitialized in this function
i tend to agree with gcc - there are a couple of plausible exit paths from audit_filter_user_rules() where it does not set 'state', keeping the variable uninitialized. For example if a filter rule has an AUDIT_POSSIBLE action. Initialize to 'wont audit'. Fix whitespace damage too.
Signed-off-by: Ingo Molnar <mingo@elte.hu>
Index: linux/kernel/auditfilter.c =================================================================== --- linux.orig/kernel/auditfilter.c +++ linux/kernel/auditfilter.c @@ -1601,8 +1601,8 @@ static int audit_filter_user_rules(struc int audit_filter_user(struct netlink_skb_parms *cb, int type) { + enum audit_state state = AUDIT_DISABLED; struct audit_entry *e; - enum audit_state state; int ret = 1; rcu_read_lock(); - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |