Messages in this thread | | | Date | Fri, 12 Jan 2007 13:25:13 -0800 | From | Paul Jackson <> | Subject | Re: - sys_mbind-use-cpuset-accessors-for-mems_allowed.patch removed from -mm tree |
| |
Andrew, regarding a patch by Andy: > + nodemask_t allowed_nodes; > > err = get_nodes(&nodes, nmask, maxnode); > - nodes_and(nodes, nodes, current->mems_allowed); > + allowed_nodes = cpuset_mems_allowed(current);
Not that it matters now, as we're messing with other variations, but I notice that the above is (1) better looking than having an #ifdef, (2) better than being broken in the NUMA yes, CPUSETS no, config, but (3) burdens this code with another nodemask and nodes_and() op, even in the case that CPUSETS are not configured.
-- I won't rest till it's the best ... Programmer, Linux Scalability Paul Jackson <pj@sgi.com> 1.925.600.0401 - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |