lkml.org 
[lkml]   [2006]   [Sep]   [8]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
SubjectRe: Re: [patch 6/6] process filtering for fault-injection capabilities
From
Date
Suggested changes, implemented by patch below:

1) Reorder kernel command line args alphabetically -- lets
output of `ls /debug/failslab` serve as a handy reminder
of the arg bindings.

2) Rename a variable to agree with the /debug file name.

---
lib/should_fail.c | 14 ++++++++------
1 file changed, 8 insertions(+), 6 deletions(-)

Index: linux-2.6.17/lib/should_fail.c
===================================================================
--- linux-2.6.17.orig/lib/should_fail.c
+++ linux-2.6.17/lib/should_fail.c
@@ -13,18 +13,20 @@ int setup_should_fail(struct should_fail
unsigned long interval;
int times;
int space;
- unsigned long filter;
+ unsigned long process_filter;

- /* "<probability>,<interval>,<times>,<space>,<process-filter>" */
- if (sscanf(str, "%lu,%lu,%d,%d,%lu", &probability, &interval, &times,
- &space, &filter) < 5)
- return 0;
+ /* "<interval>,<probability>,<process-filter>,<space>,<times>" */
+ if (sscanf(str, "%lu,%lu,%lu,%d,%d", &interval,
+ &probability, &process_filter, &space, &times) < 5) {
+ printk( "SHOULD_FAIL: failed to parse arguments\n");
+ return 0;
+ }

data->probability = probability;
data->interval = interval;
atomic_set(&data->times, times);
atomic_set(&data->space, space);
- data->process_filter = filter;
+ data->process_filter = process_filter;

return 1;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-08 08:39    [W:0.029 / U:12.012 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site