lkml.org 
[lkml]   [2006]   [Sep]   [22]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
Subject2.6.18 VIDIOC_ENUMSTD bug
From
Date
The v4l2 API documentation for VIDIOC_ENUMSTD says:

To enumerate all standards applications shall begin at index
zero, incrementing by one until the driver returns EINVAL.

The actual code, however, tests the index this way:

if (index<=0 || index >= vfd->tvnormsize) {
ret=-EINVAL;

So any application which passes in index=0 gets EINVAL right off the bat
- and, in fact, this is what happens to mplayer. So I think the
following patch is called for, and maybe even appropriate for a 2.6.18.x
stable release. Disagreement?

jon

Signed-off-by: Jonathan Corbet <corbet@lwn.net>

--- /k/t/2.6.18-vanilla/drivers/media/video/videodev.c 2006-09-22 16:20:56.000000000 -0600
+++ 18-mont/drivers/media/video/videodev.c 2006-09-22 14:34:14.000000000 -0600
@@ -836,7 +836,7 @@ static int __video_do_ioctl(struct inode
break;
}

- if (index<=0 || index >= vfd->tvnormsize) {
+ if (index < 0 || index >= vfd->tvnormsize) {
ret=-EINVAL;
break;
}
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2006-09-23 00:33    [W:0.022 / U:0.236 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site