Messages in this thread | | | Date | Tue, 12 Sep 2006 10:59:46 +0200 | From | "Jesper Juhl" <> | Subject | Re: [PATCH] fix warning: no return statement in function returning non-void in kernel/audit.c |
| |
On 12/09/06, Horst H. von Brand <vonbrand@inf.utfsm.cl> wrote: > Jesper Juhl <jesper.juhl@gmail.com> wrote: > > kauditd_thread() is being used in a call to kthread_run(). kthread_run() > > expects a function returning 'int' which is also how kauditd_thread() is > > declared. Unfortunately kauditd_thread() neglects to return a value > > It is an infinite loop...
I know. I'm just trying to get gcc to shut up.
> > which > > results in this complaint from gcc : > > > kernel/audit.c:372: warning: no return statement in function returning non-void > > > Easily fixed by just adding a 'return 0;' to kauditd_thread(). > > How about marking it as never returning?
Marking it NORET_TYPE doesn't do the trick, adding a 'return 0;' does. And gcc optimizes the return away anyway, so the object file doesn't increase in size, so it does no harm.
-- Jesper Juhl <jesper.juhl@gmail.com> Don't top-post http://www.catb.org/~esr/jargon/html/T/top-post.html Plain text mails only, please http://www.expita.com/nomime.html - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |